New 'Hello World' templates #1007
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! It's looking great. I have a few edits to make, but it'll be easier to do them in a follow-up PR branched off of this one — doing that now |
|
going to close this in favour of #1014 since it includes these commits |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
It was previously built on #934 but I decided to create a brand new PR from
master, since we simplifiedcreate-svelterecently (getting several conflicts).This PR aims basically to add a new 'Hello World' page as it was requested by #90.
Figma File by @vedam
We're adding two variants of it:
Tests
pnpm testand lint the project withpnpm lintCLI - Preview - (first step)
Default template - Preview
Skeleton template - Preview
Observation
I'm still performing my first baby steps with Svelte, so feel free to let me know if I can improve something 😛