Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent hooks.server code being imported into client during build #12195

Merged
merged 4 commits into from
Jun 21, 2024

Conversation

CaptainCodeman
Copy link
Contributor

@CaptainCodeman CaptainCodeman commented May 7, 2024

Server side code inside a src/hooks.server folder can result in the build trying to import the code into client side code, usually causing the build to break.

Reproduction: https://www.sveltelab.dev/egkmtnbmy05petz (execute npm run build)

It's due to the file suffix being stripped off so hooks.server matches a search for hooks when the code is looking for universal hooks. This makes the suffix matching stricter to only strip .js or .ts (AFAICT, those are the only things that should ever be matched with this fn).

Fixes: #11754


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented May 7, 2024

🦋 Changeset detected

Latest commit: 5439c7e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@eltigerchino eltigerchino changed the title Prevent hooks.server code being imported into client during build fix: prevent hooks.server code being imported into client during build May 16, 2024
@eltigerchino eltigerchino merged commit 5645614 into sveltejs:main Jun 21, 2024
8 of 12 checks passed
@eltigerchino
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error importing $env/static/private in hooks.server/index.ts in dev mode
2 participants