fix: prevent hooks.server
code being imported into client during build
#12195
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Server side code inside a
src/hooks.server
folder can result in the build trying to import the code into client side code, usually causing the build to break.Reproduction: https://www.sveltelab.dev/egkmtnbmy05petz (execute
npm run build
)It's due to the file suffix being stripped off so
hooks.server
matches a search forhooks
when the code is looking for universal hooks. This makes the suffix matching stricter to only strip.js
or.ts
(AFAICT, those are the only things that should ever be matched with this fn).Fixes: #11754
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.Edits