Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to http-status-codes #1471

Closed
wants to merge 2 commits into from
Closed

Add link to http-status-codes #1471

wants to merge 2 commits into from

Conversation

dummdidumm
Copy link
Member

@dummdidumm dummdidumm commented May 17, 2021

Closes #1439

Not all people might be familiar with status codes. Add a hint for them that they can use a library for that if they want to.

@dummdidumm dummdidumm added the documentation Improvements or additions to documentation label May 17, 2021
@Conduitry
Copy link
Member

How treeshakable is this library? Do we want to just link people to MDN instead? Or Wikipedia even?

@dummdidumm
Copy link
Member Author

I don't know. I had this in the back of my head, too. The idea of referencing a library was that in the referenced issue the problem was precisely that "I have to google this all the time", and using a library which provides autocompletion and meaningful constants would help. If we don't want to endorse a specific library or are too concerned with the additional kilobytes then I would just not merge this and close the issue. The docs already link to a list of status codes.

@benmccann
Copy link
Member

It looks like tree shaking is a work-in-progress. There's an issue tracking it prettymuchbryce/http-status-codes#55 and a PR that's been open since November prettymuchbryce/http-status-codes#64 to further improve it. Version 2.1.5-beta.1 is a lot better than the latest stable version 2.1.4. No idea when 2.1.5 might be released though

@benmccann
Copy link
Member

@Conduitry @dummdidumm any thoughts about whether we want to move forward with this PR?

@Conduitry
Copy link
Member

I still don't think we want to be even semi-blessing a random third-party library for something like this, even a popular one - especially if we have doubts about the treeshakability of the library or about what direction it might be going in.

We're already linking to an MDN page on this in the docs. If someone wants more than that, they can get it themselves, along with whatever extra bytes it comes with, which would then be their responsibility.

@dummdidumm
Copy link
Member Author

I'm indifferent. Feel free to close (and also the related issue with a short explanation why we won't do it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add HTTP Status Codes ENUM
3 participants