XFF_DEPTH_ENV #4357
Merged
XFF_DEPTH_ENV #4357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmccann
approved these changes
Mar 16, 2022
| @@ -18,6 +18,7 @@ export default function ({ | |||
| host: host_env = 'HOST', | |||
| port: port_env = 'PORT', | |||
| origin: origin_env = 'ORIGIN', | |||
| xffDepth: xff_depth_env = 'XFF_DEPTH', | |||
There was a problem hiding this comment.
No objections to this because I know it's consistent with the others, but it really seems unnecessary
There was a problem hiding this comment.
i guess the question becomes 'why is it necessary for the others but not this?' and if it isn't necessary for the others, then why do we need to make the env vars configurable at all?
|
Rich-Harris
added a commit
that referenced
this pull request
Mar 16, 2022
* [breaking] rename xForwardedForIndex to xForwardedForNumProxies * add back link to blog post * changeset * update based on code review * update changeset * XFF_DEPTH_ENV (#4357) * use XFF_DEPTH_ENV * get rid of get_xff_depth * typo * Update packages/adapter-node/README.md Co-authored-by: Maurício Kishi <mrkishi@users.noreply.github.com> * Update packages/adapter-node/README.md * Update README.md * overhaul readme Co-authored-by: Rich Harris <richard.a.harris@gmail.com> Co-authored-by: Maurício Kishi <mrkishi@users.noreply.github.com> Co-authored-by: Rich Harris <hello@rich-harris.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
suggested changes to #4332 (cc @benmccann)