-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow symlinked assets #5089
allow symlinked assets #5089
Conversation
🦋 Changeset detectedLatest commit: 90a0204 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
prettier skip test on windows Revert "skip test on windows" This reverts commit f8e55e6. skip test completely
@anarchodin @mrkishi @Rich-Harris please have a look 🪟 🔗 ⬆️ |
thank you! the correct fix looks a bit different — we can't just check the end of the path, because that won't work if the symlink source and target have different names. instead we're just checking that |
This might fix #4709
my monorepo setup uses symlinked static assets, and it worked great until #5047 !
I believe that check for the casing was too restrictive, so I went ahead and made this PR addressing the issue. There's a test included in the
basics
app. The issue really only applies to dev, since the build copies symlink contents transparently.Thanks in advance for the review 🙏
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0