fix manifest not updating on route creation

[gtm-nayan]

Just checking CI for now, hopefully won't break #4997 (merci Windows gods 🙏) Yayy

Fixes #5142

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

• It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
• This message body should clearly illustrate what problems it solves.
• Ideally, include a test that fails without this PR but passes with it.

Tests

• Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

• If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

[changeset-bot]

🦋 Changeset detected

Latest commit: 2a96daf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@sveltejs/kit	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[gtm-nayan]

Not sure what to do about tests, this test should've caught #5142, no?

[benmccann]

I ran test/apps/basics and created a new route as that test does. I didn't have any problem visiting the new route, but when I visited /routing again the page contents were totally different. Maybe we should update test to also visit /routing and check that "Great success!" is on the page or something along those lines

[gtm-nayan]

Still passes, it shows the correct text for a brief moment before it changes to the wrong one during hydration. Is there a way to wait for hydration to complete or should I just add a timeout?

[Rich-Harris]

page.goto already waits for hydration...

kit/packages/kit/test/utils.js

Lines 108 to 121 in 588ea0f

	const goto = page.goto;
	page.goto =
	/**
	* @param {string} url
	* @param {object} opts
	*/
	async function (url, opts) {
	const res = await goto.call(page, url, opts);
	if (javaScriptEnabled) {
	await page.waitForSelector('body.started', { timeout: 5000 });
	}
	return res;
	};
	await use(page);

...which basically means you can only test non-hydrated content by checking !javaScriptEnabled

[benmccann]

It's weird the text is updating. The test only runs if JavaScript is not enabled

[gtm-nayan]

If it's not skipped when javascriptEnabled is true, then it errors with
waiting for selector "body.started" to be visible

This means it's failing the hydration right? Even before the assertion

[gtm-nayan]

Lol if I use something like zzz.svelte instead of bar it actually fails at the right point because it loads the wrong route when navigating to zzz,

no clue why it doesn't work with bar

I'll run it a few more times to see if it's reliable or not

[gtm-nayan]

Failing test is from adapter-static, it passed in the previous run

[Rich-Harris]

👍