Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass adapters directly to config #579

Merged
merged 3 commits into from
Mar 19, 2021
Merged

Pass adapters directly to config #579

merged 3 commits into from
Mar 19, 2021

Conversation

Rich-Harris
Copy link
Member

Closes #439. Slightly unfortunate that this requires turning the adapters back into CommonJS packages, but I think this is a fundamentally better design.

Copy link
Member

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this API more. Hopefully this still works with "type": "module" in the user's package.json. I think it should

@Rich-Harris
Copy link
Member Author

It will work, yeah, you just can't go the other way (a CommonJS file can't import ESM)

@Rich-Harris Rich-Harris merged commit 8805c6d into master Mar 19, 2021
@Rich-Harris Rich-Harris deleted the commonjs-adapters branch March 19, 2021 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pass adapters to config directly?
2 participants