Add basic smoke tests for adapter-node #807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samccone
force-pushed
the
sjs/basic-adapter-node-smoke
branch
2 times, most recently
from
23a74f5
to
a056e19
Compare
5 tasks
Rich-Harris
requested changes
Mar 31, 2021
samccone
force-pushed
the
sjs/basic-adapter-node-smoke
branch
from
a056e19
to
fac3f06
Compare
samccone
force-pushed
the
sjs/basic-adapter-node-smoke
branch
2 times, most recently
from
03fcaf2
to
66d576e
Compare
Rich-Harris
requested changes
Mar 31, 2021
samccone
force-pushed
the
sjs/basic-adapter-node-smoke
branch
3 times, most recently
from
037a582
to
20301ec
Compare
* verify the server starts * verify it can serve a 404 --- Additional changes: - change server.js to be a function that creates the server but does not start it. - update build rules to build from a new index.js file that builds and starts the app - update the package type to module to enable esm imports - expose a way to call into server with a render function - add a guard clause around no static asset folder existing. - change imports in adapter-node to work with import and not require BUG sveltejs#639
samccone
force-pushed
the
sjs/basic-adapter-node-smoke
branch
from
20301ec
to
1ac6245
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope of the test
Additional changes:
starts the app