Fix scrollbar to draggable #299
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #276 and sveltejs/kit#12423.
The commit that added
height:100%;7b60778#diff-646c4a4d8d44a37b1082a9dcec99774de9b88f93945e7843d4b0e9e606a24de0R88 fixed sveltejs/kit#10292 and in my testing the browser still correctly scrolls back to correct position when pressing the back button after my commit.Related:
There was a past scrollbar issue sveltejs/svelte#5325 that was fixed by removing
height:100%;from the main tag sveltejs/svelte@a1af1e5 (before it was moved to a separate repo/component in sveltejs/svelte@bad1780#diff-81aa9fa32da25a5a82688cc86ff1689b70824846d2eeaac912d6cdb6059fb054L62 ).