Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS bug in the REPL #372

Closed
mindplay-dk opened this issue Mar 14, 2017 · 4 comments
Closed

CSS bug in the REPL #372

mindplay-dk opened this issue Mar 14, 2017 · 4 comments

Comments

@mindplay-dk
Copy link

The CSS randomly does or doesn't seem to apply in the REPL.

Adding some random whitespace to the CSS often makes it work, but removing the whitespace again makes the CSS drop off again.

css-bug-in-repl

I would post a REPL link, but the "output" and "save" buttons also don't seem to work in the REPL now?

Here's a link to my gist:

https://gist.github.com/mindplay-dk/d85fbf5427d5e4436fadc70ce46d9ac2

@Rich-Harris
Copy link
Member

Thanks for the repro — I think this is related to #366 (comment), I'm going to revert that change in the next version later today, hopefully that will fix it

@Conduitry
Copy link
Member

Conduitry commented Mar 14, 2017

It looks like the issue with the buttons not working in the REPL is the ul.sidebar element overlapping the buttons. Bumping up the z-index on section.repl-container seems to resolve it, but I don't know whether there's another better solution or how the sidebar is supposed to be working - is that part of the new mobile-friendly navigation?

@Rich-Harris
Copy link
Member

Gah. That'll be fixed very soon with sveltejs/v2.svelte.dev#56

Rich-Harris added a commit that referenced this issue Mar 15, 2017
revert to previous addCss behaviour
@Rich-Harris
Copy link
Member

Fixed in 1.11.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants