Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Fix HTML escaping and non-top-level <script> and <style> issues #1086

Merged
merged 7 commits into from
Jan 9, 2018
Merged

[WIP] Fix HTML escaping and non-top-level <script> and <style> issues #1086

merged 7 commits into from
Jan 9, 2018

Commits on Jan 8, 2018

  1. in stringified Text nodes, only escape &, <, >

    @Conduitry
    Conduitry committed Jan 8, 2018
    Configuration menu
    Copy the full SHA
    8c8f970 View commit details
    Browse the repository at this point in the history

  2. parse non-top-level <script> and <style> tags as one piece of Text

    @Conduitry
    Conduitry committed Jan 8, 2018
    Configuration menu
    Copy the full SHA
    41744e2 View commit details
    Browse the repository at this point in the history

  3. store <script> and <style> contents on Element node itself

    @Conduitry
    Conduitry committed Jan 8, 2018
    Configuration menu
    Copy the full SHA
    c42e6f9 View commit details
    Browse the repository at this point in the history

  4. update SSR rendering of <script> and <style>

    @Conduitry
    Conduitry committed Jan 8, 2018
    Configuration menu
    Copy the full SHA
    1f229cf View commit details
    Browse the repository at this point in the history

  5. update DOM rendering of <script> and <style>

    @Conduitry
    Conduitry committed Jan 8, 2018
    Configuration menu
    Copy the full SHA
    00a0445 View commit details
    Browse the repository at this point in the history

  6. update test

    @Conduitry
    Conduitry committed Jan 8, 2018
    Configuration menu
    Copy the full SHA
    fbb856e View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2018

  1. add test to ensure only <, > and & are escaped

    @Rich-Harris
    Rich-Harris committed Jan 9, 2018
    Configuration menu
    Copy the full SHA
    f6e6cb6 View commit details
    Browse the repository at this point in the history