-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: auto-open a tbody when we detect we need it #12628
Conversation
- relax validation in some places where we know the HTML will not break or only break when using SSR - consolidate validation in one place and for better reuse, which results in more cases getting caught at runtime closes #11941
…ly fails because the dom walking mechanism needs to know that it should walk differently in that case
|
IMHO its better when I know I did something wrong to go and fix it, rather than it being automatically fixed and me not knowing it. If this is the chosen direction of things, can we have warning when svelte repairs markup?
IMHO this is the lands of unkown magic where harry potter lives :D |
Having thought through this a bit more I've changed my tune — there's too much scope for ambiguity. Like, if I have something like this... <table>
<tr>...</tr>
{#each things as thing}
<tr>...</tr>
{/each}
<tr>...</tr>
</table> ...where do the |
They are only warnings because it won't cause DOM repairing when you're not using SSR. In case you do, it will fail with an explicit error on SSR at runtime. |
WIP because it currently fails because the dom walking mechanism needs to know that it should walk differently in that case
Svelte 5 rewrite
Please note that the Svelte codebase is currently being rewritten for Svelte 5. Changes should target Svelte 5, which lives on the default branch (
main
).If your PR concerns Svelte 4 (including updates to svelte.dev.docs), please ensure the base branch is
svelte-4
and notmain
.Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.Tests and linting
pnpm test
and lint the project withpnpm lint