-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: more process_effect
tweaks
#13315
Conversation
|
var is_branch = (flags & BRANCH_EFFECT) !== 0; | ||
var is_clean = (flags & CLEAN) !== 0; | ||
var child = current_effect.first; | ||
var is_skippable_branch = is_branch && (flags & CLEAN) !== 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we could do this instead which would presumably be a tiny bit faster, but less readable
var is_skippable_branch = is_branch && (flags & CLEAN) !== 0; | |
var is_skippable_branch = (flags & (CLEAN | BRANCH_EFFECT)) === (CLEAN | BRANCH_EFFECT); |
we can make things a tiny bit smaller/faster
Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.Tests and linting
pnpm test
and lint the project withpnpm lint