Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

require void elements to be lowercase #138

Merged
merged 1 commit into from
Dec 7, 2016
Merged

require void elements to be lowercase #138

merged 1 commit into from
Dec 7, 2016

Conversation

Rich-Harris
Copy link
Member

Fixes #137. Not entirely uncontroversial, since <IMG> and <LINK> etc are valid HTML, but the alternative is quite tricky (we'd essentially need to parse twice, which is a lot of extra work to handle a real edge case).

Any thoughts?

@evs-chris
Copy link
Contributor

👍 Only heathens use upper-case tag names, leave their elements open, and don't quote attributes. 😆 Seriously though, if you want to be super accommodating, you could leave it case sensitive and throw in the all-upper-case variations too.

@Rich-Harris
Copy link
Member Author

if you want to be super accommodating

Good point, that would be doable. Going to put it in the nice-to-have pile for now though 😀

@Rich-Harris Rich-Harris merged commit b81ff3e into master Dec 7, 2016
@Andorbal
Copy link

Andorbal commented Dec 7, 2016

I like requiring void elements to be lowercase. It may catch someone of guard the very first time they try to use IMG, but as long as the error says what's wrong, I think the consistency is worth it.

@Swatinem Swatinem deleted the gh-137 branch December 8, 2016 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants