Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle await block promises in a shared helper #1418

Merged
merged 6 commits into from
May 5, 2018
Merged

Conversation

Rich-Harris
Copy link
Member

Trying to tidy some of this stuff up in order to tackle #956. Will try and fix #1417 in this PR as well.

It results in slightly more code if you have one await block in an app, but less if you have two or more.

@codecov-io
Copy link

codecov-io commented May 5, 2018

Codecov Report

Merging #1418 into master will increase coverage by 0.02%.
The diff coverage is 90.9%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1418      +/-   ##
=========================================
+ Coverage   91.18%   91.2%   +0.02%     
=========================================
  Files         122     122              
  Lines        4490    4481       -9     
  Branches     1386    1390       +4     
=========================================
- Hits         4094    4087       -7     
+ Misses        154     153       -1     
+ Partials      242     241       -1
Impacted Files Coverage Δ
src/compile/dom/Block.ts 93.39% <ø> (ø) ⬆️
src/shared/utils.js 100% <ø> (ø) ⬆️
src/compile/nodes/AwaitBlock.ts 95.65% <90.9%> (+2.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9883fb6...8d772b1. Read the comment docs.

@Rich-Harris Rich-Harris merged commit 49c594e into master May 5, 2018
@Rich-Harris Rich-Harris deleted the await-helper branch May 5, 2018 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Await blocks with no dynamic content behave incorrectly
2 participants