Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclude current prop in computed properties using entire state #1544 #1652

Merged
merged 1 commit into from
Aug 15, 2018

Conversation

Conduitry
Copy link
Member

Similar to what was done with rest params in computed properties, but does the same excluding-the-current-prop thing when computed properties don't use destructuring and thus depend on the entire state.

@Conduitry
Copy link
Member Author

cc @fjorgemota @TehShrike

@fjorgemota
Copy link
Contributor

Nice! Seems good!

Thanks @Conduitry!

@Rich-Harris Rich-Harris merged commit 4ce2e1d into master Aug 15, 2018
@Rich-Harris Rich-Harris deleted the gh-1544-computed-whole-state branch August 15, 2018 00:19
@Rich-Harris
Copy link
Member

d'oh! i really went out of my way to preserve this bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants