Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes shorthand class directives which do not have classes #1749

Merged
merged 1 commit into from
Sep 19, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/compile/nodes/Element.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1326,7 +1326,7 @@ export default class Element extends Node {
dependencies = expression.dependencies;
} else {
snippet = `ctx${quotePropIfNecessary(name)}`;
dependencies = [name];
dependencies = new Set([name]);
}
const updater = `@toggleClass(${this.var}, "${name}", ${snippet});`;

Expand Down
16 changes: 16 additions & 0 deletions test/runtime/samples/class-shortcut-with-class/_config.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
export default {
data: {
"is-active": true,
isSelected: true,
myClass: 'one two'
},
html: `<div class="one two is-active isSelected"></div>`,

test ( assert, component, target, window ) {
component.set({ "is-active": false });

assert.htmlEqual( target.innerHTML, `
<div class="one two isSelected"></div>
` );
}
};
1 change: 1 addition & 0 deletions test/runtime/samples/class-shortcut-with-class/main.html
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
<div class="{ myClass }" class:is-active class:isSelected class:not-used></div>
7 changes: 3 additions & 4 deletions test/runtime/samples/class-shortcut/_config.js
Original file line number Diff line number Diff line change
@@ -1,16 +1,15 @@
export default {
data: {
"is-active": true,
isSelected: true,
myClass: 'one two'
isSelected: true
},
html: `<div class="one two is-active isSelected"></div>`,
html: `<div class="is-active isSelected"></div>`,

test ( assert, component, target, window ) {
component.set({ "is-active": false });

assert.htmlEqual( target.innerHTML, `
<div class="one two isSelected"></div>
<div class="isSelected"></div>
` );
}
};
2 changes: 1 addition & 1 deletion test/runtime/samples/class-shortcut/main.html
Original file line number Diff line number Diff line change
@@ -1 +1 @@
<div class="{ myClass }" class:is-active class:isSelected class:not-used></div>
<div class:is-active class:isSelected class:not-used></div>