Improve typings #2838
Merged
Improve typings #2838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 21, 2019
Merged
|
Thank you, this is positively heroic! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While exploring code base, found that some typings are incomplete or incorrect… And so I decided to fix it.
In this PR, I fixed types, to make typescript happy - now typecheck can complete without errors.
This can be the first step on a way to start having more strict typechecks.
Also, added
typecheckcommand in npm scripts, would be nice to add it to CI, but I am not sure where exactly to add it.In some places, where I am not sure what typings should be, or suspect there might be actual error - I added
ts-ignorewith additional comments, I would suggest - someone with deeper knowledge about codebase to review and to fix that cases properly.