Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent outro callback corruption #3209

Merged
merged 3 commits into from
Jul 10, 2019
Merged

Prevent outro callback corruption #3209

merged 3 commits into from
Jul 10, 2019

Conversation

Rich-Harris
Copy link
Member

This fixes the second bug in #2086, in which nested keyed each blocks could create a situation in which outro callbacks got corrupted. Also brings a test over from #3159

@antony
Copy link
Member

antony commented Jul 9, 2019

Why the obfuscation of remaining to r and callbacks to c? This is fine for function-local variables but in this instance makes the code significantly harder to reason about? There is no notion of what c and r mean.

@Rich-Harris
Copy link
Member Author

They're only referenced in this file, and I've added comments at the declaration site. Just figured the extra bytes were unnecessary

@Rich-Harris Rich-Harris changed the title Gh 2086 2 Prevent outro callback corruption Jul 9, 2019
@antony
Copy link
Member

antony commented Jul 9, 2019

Ah I missed the comments - I don't read comments as I think they are dangerous, but I respect your programming style :)

@Rich-Harris Rich-Harris merged commit 283152f into master Jul 10, 2019
@Rich-Harris Rich-Harris deleted the gh-2086-2 branch July 10, 2019 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants