Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #3508 #3573

Closed

Conversation

damianpumar
Copy link
Contributor

Fix issue #3508
Added runtime tests

To Reproduce before Fix:
https://svelte.dev/repl/e694e7e20f044deabaf55ff659a1e41e?version=3.9.2

Expected behavior
Expected that binding to an alias would be consistent with binding to an unaliased export.

@codecov-io
Copy link

codecov-io commented Sep 15, 2019

Codecov Report

Merging #3573 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3573   +/-   ##
=======================================
  Coverage   50.25%   50.25%           
=======================================
  Files           1        1           
  Lines         197      197           
=======================================
  Hits           99       99           
  Misses         98       98

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14a46a1...20670aa. Read the comment docs.

@Conduitry
Copy link
Member

I don't think this is quite the right solution. If, for some reason, the component had another unhoistable local variable with the same name as the alias of the export, this would cause that key to appear twice in the object returned by the instance function. I'm not sure what the right solution is though. It might require more sweeping changes.

(This PR is also now conflicted with master that #3539 has been merged in.)

@Conduitry Conduitry closed this Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants