skip comments for preprocessors #3894
Conversation
src/compiler/preprocess/index.ts
Outdated
| }) as Replacement | ||
| ) | ||
| ); | ||
| str.replace(re, (match, attributes, content, offset) => { |
There was a problem hiding this comment.
Were you just making this change for code style reasons? Part of the reason it was written like it was was so that replace_async would work with arbitrarily many capture groups. With these changes, it looks like this will only work with exactly two capture groups. Any more or fewer won't be passed on to the callback correctly, and offset will also receive the wrong argument.
tanhauhau
force-pushed
the
tanhauhau/skip-comment-for-preprocessors
branch
from
08acda4
to
5c53cf2
Compare
src/compiler/preprocess/index.ts
Outdated
| }) as Replacement | ||
| ) | ||
| ); | ||
| if (args.slice(1, args.length - 2).some(Boolean)) { |
There was a problem hiding this comment.
I'm still not sure what the changes to replace_async are for. The intention was that it be a low-level utility function, behaving a lot like String.prototype.replace, except able to work with callbacks that return promises. If you need different behavior than that, it should be handled in the callback you pass to replace_async.
There was a problem hiding this comment.
oh yea you are right. i've updated my changes.
tanhauhau
force-pushed
the
tanhauhau/skip-comment-for-preprocessors
branch
from
5c53cf2
to
3fb9626
Compare
Fix #3047 (comment)
need to skip html comments when
regexping<script>and<style>tag.