Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat no invalidate reactive vars if dependencies are all static #4066

Conversation

tanhauhau
Copy link
Member

was looking at #4018 + playing around with the repl,

realise that if the dependencies of the reactive statements are static, there's no need to call $$invalidate.

@tanhauhau tanhauhau force-pushed the tanhauhau/no-invalidate-static-reactive branch from dc13b0b to aaceaf9 Compare December 7, 2019 14:57
@ghost
Copy link

ghost commented Dec 9, 2019

EDIT: scratch all my previous comments as all the work is done compile time.

Anyways, I'd be worried about introducing a regression where something doesn't update when it should.

@Conduitry Conduitry marked this pull request as draft August 12, 2020 19:44
@stale
Copy link

stale bot commented Jun 26, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale-bot label Jun 26, 2021
@stale stale bot removed the stale-bot label Jun 26, 2021
@stale stale bot removed the stale-bot label Jun 27, 2021
@tanhauhau tanhauhau force-pushed the tanhauhau/no-invalidate-static-reactive branch from aaceaf9 to 5177602 Compare October 14, 2022 03:13
@tanhauhau tanhauhau marked this pull request as ready for review October 14, 2022 03:15
@tanhauhau tanhauhau force-pushed the tanhauhau/no-invalidate-static-reactive branch from 5177602 to a88e4ee Compare October 14, 2022 03:18
@tanhauhau tanhauhau closed this Oct 14, 2022
@tanhauhau tanhauhau reopened this Oct 14, 2022
@tanhauhau tanhauhau closed this Oct 14, 2022
@tanhauhau
Copy link
Member Author

somehow the pipeline fails to install, even though it works locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants