Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Buble transforms not needed for Node 4 #411

Merged
merged 2 commits into from
Mar 27, 2017

Conversation

Conduitry
Copy link
Member

Many of the transforms being done by Buble aren't required for Node 4. Disabling them is nicer, and also slightly decreases the size of the bundle - down from 385KB to 375KB.

@Rich-Harris
Copy link
Member

Good catch. We can actually get exactly the same result by using target: { node: 4 }, not sure why I didn't do that in the first place — added a commit. Slightly more futureproof (if we were to start using other ES6 features that Buble supports and Node 4 doesn't), and easier to drop support for Node 4 when the time comes.

@Rich-Harris Rich-Harris merged commit b9d3c23 into master Mar 27, 2017
@Rich-Harris Rich-Harris deleted the disable-unneeded-buble-transforms branch March 27, 2017 12:53
@Swatinem
Copy link
Member

drop support for Node 4

soon…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants