-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP fix for #4731: preserveWhitespace in SSR #4737
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since htmlEqual uses normalizeHtml that removes whitespace.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
5 tasks
himanshiLt
pushed a commit
to himanshiLt/svelte
that referenced
this pull request
Mar 3, 2022
…tejs#6990) Fixes sveltejs#6437 Fixes sveltejs#4731 Closes sveltejs#4737 Whitespace is now untouched inside <pre> tag and other tags if preserveWhitespace is true
nevilm-lt
pushed a commit
to nevilm-lt/svelte
that referenced
this pull request
Mar 14, 2022
…tejs#6990) Fixes sveltejs#6437 Fixes sveltejs#4731 Closes sveltejs#4737 Whitespace is now untouched inside <pre> tag and other tags if preserveWhitespace is true
nevilm-lt
pushed a commit
to nevilm-lt/svelte
that referenced
this pull request
Apr 21, 2022
…tejs#6990) Fixes sveltejs#6437 Fixes sveltejs#4731 Closes sveltejs#4737 Whitespace is now untouched inside <pre> tag and other tags if preserveWhitespace is true
nevilm-lt
pushed a commit
to nevilm-lt/svelte
that referenced
this pull request
Apr 21, 2022
…tejs#6990) Fixes sveltejs#6437 Fixes sveltejs#4731 Closes sveltejs#4737 Whitespace is now untouched inside <pre> tag and other tags if preserveWhitespace is true
nevilm-lt
pushed a commit
to nevilm-lt/svelte
that referenced
this pull request
Apr 22, 2022
…tejs#6990) Fixes sveltejs#6437 Fixes sveltejs#4731 Closes sveltejs#4737 Whitespace is now untouched inside <pre> tag and other tags if preserveWhitespace is true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP fix for #4731.
Why this is still work in progress:
the test works, but don't currently fail, becausehtmlEqual
usesnormalizeHtml
which strips spaces & comments (same problem as Fix perserveComments on ssr (#4730) #4736), any advise?Update: solved by updating the testing code in #f2e0479
_actual.html
, but are in working with full samples, what am I missing?option
in{#each}
-loop still don't preserve whitespace (was looking atshould_skip
insrc/compiler/compile/render_dom/wrappers/Text.ts
)Update: both open issues seem to be related to
should_skip
insrc/compiler/compile/nodes/Text.ts
, for some reason this check doesn't work (preserveWhitespace
seems to be false):