Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make builds time out after a reasonable period #5100

Merged
merged 1 commit into from
Jul 7, 2020
Merged

make builds time out after a reasonable period #5100

merged 1 commit into from
Jul 7, 2020

Conversation

antony
Copy link
Member

@antony antony commented Jul 4, 2020 •
edited
Loading

Not sure if we pay any bills for CI, but some builds get stuck for half a day. This will stop that.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR relates to an outstanding issue, so please reference it in your PR, or create an explanatory one for discussion. In many cases, features are absent for a reason.
  • This message body should clearly illustrate what problems it solves. If there are related issues, remember to reference them.
  • Ideally, include a test that fails without this PR but passes with it. PRs will only be merged once they pass CI. (Remember to npm run lint!)

Tests

  • Run the tests with npm test or yarn test)

@antony antony self-assigned this Jul 4, 2020
@antony antony added the meta label Jul 4, 2020
@Conduitry Conduitry merged commit 3f99e51 into sveltejs:master Jul 7, 2020
hontas added a commit to hontas/svelte that referenced this pull request Jul 18, 2020
@hontas
Merge remote-tracking branch 'upstream/master'
b1fc702 
* upstream/master: (190 commits)
  invalidate $$props and $$restProps only when there are changes (sveltejs#5123)
  site: use https in link in blog (sveltejs#5148)
  Simplify each block bindings example (sveltejs#5094)
  fix $$props reactive for slots (sveltejs#5125)
  site: add FAQ entry for how to document a svelte component (sveltejs#5131)
  site: remove an obsolete TODO in blog post (sveltejs#5135)
  Increase timeout for unit build
  Increase timeout for unit tests
  -> v3.24.0
  spread condition for input element (sveltejs#5004)
  update changelog
  fix(5018): compare wholeText instead of data (sveltejs#5028)
  html anchor in head (sveltejs#5071)
  error on expression scope store (sveltejs#5079)
  update changelog
  preprocess self-closing script and style tags (sveltejs#5082)
  update changelog
  fix: Parameters with default values are optional (sveltejs#5083)
  make builds time out after a reasonable period (sveltejs#5100)
  site: fix blog typo (sveltejs#5090)
  ...
@antony antony deleted the feature/build-timeout branch September 15, 2020 16:15
taylorzane pushed a commit to taylorzane/svelte that referenced this pull request Dec 17, 2020
@antony @taylorzane
make builds time out after a reasonable period (sveltejs#5100)
53b9fd2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@antony antony

Labels
meta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antony @Conduitry