feat(a11y): add no-redundant-roles rule (#820) #5361
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- flagging easy cases of redundant aria roles on html tags for now Signed-off-by: mhatvan <markus_hatvan@aon.at>
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
@pngwn This PR is now more than a year old, is there a chance to get this reviewed/approved? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a rough version of no-redundant-roles lint rule from #820.
I went through all HTML tags listed on https://www.w3.org/TR/html-aria/#docconformance and made sure to be able to lint easy cases for redundant roles like e.g. on a
<button>element.I skipped the difficult implementation parts for now, e.g. for the
<header>element, which would need to be aware of its parent node or if that parent node has a potentially assigned role.The HTML tags that would require a more complex implementation logic are commented out for now in the
implicitAriaSemanticsMap.It is up to the core team to decide if this lint rule should become more complex and therefore time-consuming for maintaining it with potential bugs or not.