ensure outroing each block iterations don't jump to the top #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #568 +/- ##
==========================================
+ Coverage 94.45% 94.48% +0.02%
==========================================
Files 95 95
Lines 2761 2776 +15
==========================================
+ Hits 2608 2623 +15
Misses 153 153
Continue to review full report at Codecov.
|
|
Seems like it works:
I think there's a bug in the unkeyed version, it occasionally gets out of whack if you jab the button often enough. |
|
REPL link for the above, once this is merged: https://svelte.technology/repl?gist=1bad0d47afc0a6e9344b40a65d44f701 |
Rich-Harris
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will explain this work in #373. The placement of outroing nodes is still wrong — that's the final part, and my brain is too melted at this point to figure it out.