Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove node<14 tests #8482

Merged
merged 5 commits into from
Apr 11, 2023

Conversation

dummdidumm
Copy link
Member

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

@vercel
Copy link

vercel bot commented Apr 11, 2023

@dummdidumm is attempting to deploy a commit to the Svelte Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to ask if we should keep 12 for awhile longer, but 20 comes out next week and 14 is EOL at the end of the month, so I think supporting 14 still is generous enough

Copy link
Member

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but will need to fix the test failures before merging

chcp 65001
echo ("NODE_VERSION=$(node --version)") >> $env:GITHUB_ENV
if: runner.os == 'Windows'
- run: npm install --save-dev puppeteer@13
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we would still need this, but I upgraded puppeteer so that it's no longer necessary and we can run the tests locally. I can reproduce the test failures locally, but have no clue why they're happening

@benmccann
Copy link
Member

benmccann commented Apr 11, 2023

Hmm. Maybe the test failures are related to some of the recently merged PRs. I see it expecting add_resize_listener, which was removed in #8022 and I see the tests also failing in master since that PR.

@benmccann benmccann merged commit c729829 into sveltejs:version-4 Apr 11, 2023
@benmccann benmccann added this to the 4.x milestone Apr 12, 2023
dummdidumm added a commit that referenced this pull request Apr 18, 2023
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
@gtm-nayan gtm-nayan mentioned this pull request Jun 17, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants