pass default onwarn and onerror handlers to user's callbacks #883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conduitry
force-pushed
the
default-onwarn-onerror
branch
from
40de1f1
to
0567d08
Compare
|
I think that's exactly the right approach, and it'll become particularly useful once warnings are objects with codes etc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #824. This is a bit hacky but it seemed to be the most localized change that addresses this. Basically I'm replacing
options.onwarnandoptions.onerrorwith versions that take one argument (the warning/error) and call the user's original callback with two arguments (the warning/error and the default handlers). The reason for this was so that the several places whereoptions.onwarnandoptions.onerrorare called can all remain the same. This can be changed if that seems a bit too hacky.