Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: shrink custom element baseline a bit #8858

Merged
merged 2 commits into from
Jul 3, 2023
Merged

fix: shrink custom element baseline a bit #8858

merged 2 commits into from
Jul 3, 2023

Conversation

dummdidumm
Copy link
Member

  • use shorter class property names as they are not minified
  • reuse some dom helper methods

#8826

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

- use shorter class property names as they are not minified
- reuse some dom helper methods

#8826
$$connected = false;
$$data = {};
$$reflecting = false;
$$ctor;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would put comments next to each of these with their old names or describing what they hold as it might be hard to figure out from just the single-letter abbreviation

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preferably JSDoc comments above so that they show up when hovering over where the properties are used.

@dummdidumm dummdidumm merged commit 4b3eb72 into master Jul 3, 2023
6 checks passed
@dummdidumm dummdidumm deleted the ce-size branch July 3, 2023 12:45
@github-actions github-actions bot mentioned this pull request Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants