Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle sending moneybird sync error with any object #3781

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

DeD1rk
Copy link
Member

@DeD1rk DeD1rk commented Aug 28, 2024

This solves an issue where an exception was raised during handling of another catchable exception. Should make the synchronization more robust if anything weird happens, rather than crashing it.

Closes https://thalia.sentry.io/issues/5732597819/.

This solves an issue where an exception was raised during handling of another catchable exception. Should make the synchronization more
robust if anything weird happens, rather than crashing it.
@DeD1rk DeD1rk added bug Something that should be fixed app:moneybirdsynchronization Issues regarding the Moneybird synchronization labels Aug 28, 2024
@DeD1rk DeD1rk merged commit 09f13c0 into master Aug 28, 2024
10 checks passed
@DeD1rk DeD1rk deleted the fix-crash-during-moneybird-sync-exception-handling branch August 28, 2024 18:02
T8902 pushed a commit that referenced this pull request Aug 28, 2024
This solves an issue where an exception was raised during handling of another catchable exception. Should make the synchronization more
robust if anything weird happens, rather than crashing it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:moneybirdsynchronization Issues regarding the Moneybird synchronization bug Something that should be fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants