[aspnet] Initial implementation of ASP.NET 5 server #2024
Conversation
Things to work on: Gaps: * Missing swagger definition functionality: - defaultResponse - examples - auth - consumes - produces - nickname - externalDocs - imports - security - schema * Resolve allParams/hasMore issue with headerParams * Create functional test project stub * Resolve all issues with value type return values In this commit: * Initial cross-platform ASP.NET 5 API server * Hook up swagger gen via Swashbuckle and xml comment * Build script (*nix) in project root * Dockerfile for container deployment
|
@jimschubert thank you 🍻 I'll review and let you know if I've any questions. |
|
@wing328 Thanks. It generates a pretty complete server. Nothing snazzy like services or DI. Just pushed a second commit to fix a bad merge of the Haskell Servant example in README.md when I rebased. I did have to add a hack for operation paths. Something like |
| /// <summary> | ||
| /// {{description}} | ||
| /// </summary> | ||
| public class {{classname}} : {{#parent}}{{{parent}}}, {{/parent}} IEquatable<{{classname}}> |
There was a problem hiding this comment.
[OPTIONAL] we just added partial to the model class. You might want to do the same.
There was a problem hiding this comment.
I can add that. After we recently regenerated the C# client at work, I was thinking about how nice it would be if this was had the partial keyword.
I'll look at the client code, but are there any plans or best practices for partial methods? Or just the class for now?
There was a problem hiding this comment.
To me, adding partial to model classes is just a starting point. If there're demands/use cases for adding partial to methods or other classes, we'll definitely consider it.
|
[OPTIONAL] you may also want add |
|
@wing328 I made those changes. Let me know if there's anything else you find. |
|
Looks good to me. |
[aspnet] Initial implementation of ASP.NET 5 server
See Issue #1469
Things to work on:
Gaps:
In this commit: