Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Typescript-Fetch] Support additionalproperties and more. #6093

Closed
wants to merge 10 commits into from
Closed

[Typescript-Fetch] Support additionalproperties and more. #6093

wants to merge 10 commits into from

Conversation

isman-usoh
Copy link
Contributor

@isman-usoh isman-usoh commented Jul 17, 2017

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master for non-breaking changes and 3.0.0 branch for breaking (non-backward compatible) changes.

Description of the PR

  • Upgrade to TypeScript 2
  • Use type definition from npm instead of typings, typings is deprecation
  • Use Enum instead of String Literal Types
  • Use typescript es6 lib for target es5
  • Support additionalproperties
  • Support JSDoc
  • Add snapshot and npmRepository option
  • Update typescript-fetch run script for linux
  • Create typescript-fetch run script for windows

- Update typescript-fetch bin for linux
- Create typescript-fetch bin for windows
- Upgrade to TypeScript 2
- Use type definition from npm Instead of from Typings
- Use Enum Instead of String Literal Types
- Use typescript es6 lib for target es5
- Support additionalproperties
- Support JSDoc
@isman-usoh isman-usoh closed this Jul 17, 2017
@isman-usoh isman-usoh reopened this Jul 17, 2017
isman-usoh and others added 2 commits July 18, 2017 19:09
… into typescript-fetch

# Conflicts:
#	bin/jaxrs-resteasy-eap-java8-petstore-server.sh
#	bin/swift3-petstore-unwraprequired.sh
#	bin/typescript-angular4-petstore-with-npm.sh
#	bin/typescript-fetch-petstore-es6.sh
#	bin/typescript-fetch-petstore-npm.sh
#	bin/typescript-fetch-petstore.sh
#	bin/windows/python2-flask-petstore.bat
#	bin/windows/python3-flask-petstore.bat
#	bin/windows/typescript-angular2-petstore-all.bat
#	modules/swagger-codegen/src/main/java/io/swagger/codegen/languages/TypeScriptFetchClientCodegen.java
#	modules/swagger-codegen/src/main/resources/TypeScript-Fetch/api.mustache
#	modules/swagger-codegen/src/main/resources/tizen/generateDocumentation.mustache
#	samples/client/petstore-security-test/typescript-fetch/api.ts
#	samples/client/petstore/typescript-fetch/builds/default/.swagger-codegen/VERSION
#	samples/client/petstore/typescript-fetch/builds/default/api.ts
#	samples/client/petstore/typescript-fetch/builds/es6-target/.swagger-codegen/VERSION
#	samples/client/petstore/typescript-fetch/builds/es6-target/api.ts
#	samples/client/petstore/typescript-fetch/builds/with-npm-version/.swagger-codegen/VERSION
#	samples/client/petstore/typescript-fetch/builds/with-npm-version/api.ts
#	samples/client/petstore/typescript-fetch/tests/npm/test/PetApi.ts
#	samples/client/petstore/typescript-fetch/tests/npm/test/PetApiFactory.ts
#	samples/client/petstore/typescript-fetch/tests/npm/test/StoreApiFactory.ts
@isman-usoh isman-usoh closed this Jul 18, 2017
@isman-usoh isman-usoh deleted the typescript-fetch branch July 18, 2017 12:18
@wing328
Copy link
Contributor

wing328 commented Jul 21, 2017

@isman-usoh Thanks for the PR. The enhancements look pretty solid 👍 . Are you going to open a new PR instead?

@wing328
Copy link
Contributor

wing328 commented Jul 21, 2017

Just saw #6130. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants