-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Typescript-Fetch] Support additionalproperties and more. #6093
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update typescript-fetch bin for linux - Create typescript-fetch bin for windows
- Upgrade to TypeScript 2 - Use type definition from npm Instead of from Typings - Use Enum Instead of String Literal Types - Use typescript es6 lib for target es5 - Support additionalproperties - Support JSDoc
… into typescript-fetch # Conflicts: # bin/jaxrs-resteasy-eap-java8-petstore-server.sh # bin/swift3-petstore-unwraprequired.sh # bin/typescript-angular4-petstore-with-npm.sh # bin/typescript-fetch-petstore-es6.sh # bin/typescript-fetch-petstore-npm.sh # bin/typescript-fetch-petstore.sh # bin/windows/python2-flask-petstore.bat # bin/windows/python3-flask-petstore.bat # bin/windows/typescript-angular2-petstore-all.bat # modules/swagger-codegen/src/main/java/io/swagger/codegen/languages/TypeScriptFetchClientCodegen.java # modules/swagger-codegen/src/main/resources/TypeScript-Fetch/api.mustache # modules/swagger-codegen/src/main/resources/tizen/generateDocumentation.mustache # samples/client/petstore-security-test/typescript-fetch/api.ts # samples/client/petstore/typescript-fetch/builds/default/.swagger-codegen/VERSION # samples/client/petstore/typescript-fetch/builds/default/api.ts # samples/client/petstore/typescript-fetch/builds/es6-target/.swagger-codegen/VERSION # samples/client/petstore/typescript-fetch/builds/es6-target/api.ts # samples/client/petstore/typescript-fetch/builds/with-npm-version/.swagger-codegen/VERSION # samples/client/petstore/typescript-fetch/builds/with-npm-version/api.ts # samples/client/petstore/typescript-fetch/tests/npm/test/PetApi.ts # samples/client/petstore/typescript-fetch/tests/npm/test/PetApiFactory.ts # samples/client/petstore/typescript-fetch/tests/npm/test/StoreApiFactory.ts
@isman-usoh Thanks for the PR. The enhancements look pretty solid 👍 . Are you going to open a new PR instead? |
Just saw #6130. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
and./bin/security/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\
.3.0.0
branch for breaking (non-backward compatible) changes.Description of the PR