Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python] Update Minimum Required Versions in setup.mustache #9211

Merged
merged 1 commit into from
Mar 1, 2019

Conversation

ustinov
Copy link
Contributor

@ustinov ustinov commented Feb 26, 2019

Set certifi to be not older than 2017.4.17 (it's the minimum version required by popular requests package)
Set python-dateutil minimum version to 2.1 (it's also minimum version required by botocore package)
Bump urllib3 minimum required version to 1.23 as there were known vulnerabilities in lesser versions
PyUp Safety DB https://pyupio.github.io/safety-db/ (look for urllib3)
Snyk Vulnerability DB https://snyk.io/vuln/search?q=urllib3&type=pip

Resolves #9201

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

(details of the change, additional tests that have been done, reference to the issue for tracking, etc)

Set `certifi` to be not older than `2017.4.17` (it's the minimum version required by popular `requests` package)
Set `python-dateutil` minimum version to `2.1` (it's also minimum version required by `botocore` package)
Bump `urllib3` minimum required version to `1.23` as there were known vulnerabilities in lesser versions
PyUp Safety DB https://pyupio.github.io/safety-db/ (look for urllib3)
Snyk Vulnerability DB https://snyk.io/vuln/search?q=urllib3&type=pip
@ustinov
Copy link
Contributor Author

ustinov commented Feb 26, 2019

CC: @kenjones-cisco

@kenjones-cisco
Copy link
Contributor

LGTM!

@ustinov ustinov changed the title Update Minimum Required Versions in setup.mustache [Python] Update Minimum Required Versions in setup.mustache Feb 26, 2019
@ustinov
Copy link
Contributor Author

ustinov commented Feb 26, 2019

Thanks for approval, @kenjones-cisco! I don't have write access here, so feel free to merge it.

@HugoMario HugoMario merged commit f5de411 into swagger-api:master Mar 1, 2019
@HugoMario
Copy link
Contributor

thanks a lot @ustinov !

@ustinov ustinov deleted the patch-1 branch March 1, 2019 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants