Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix calls to lenstronomy for new version #54

Merged
merged 3 commits into from
Jan 26, 2024

Conversation

smericks
Copy link
Collaborator

@smericks smericks commented Dec 8, 2023

  • PointSource() now takes in 'lens_model' instead of 'lensModel' as a kwarg (change to config_handler.py)
  • remove use of a private function in MainDeflector.simple_deflectors.py

@sibirrer
Copy link
Collaborator

@swagnercarena this PR should be merged ASAP to guarantee consistency with lenstronomy. I think the issue with the test failing is that paltas required an older version of lenstronomy

@swagnercarena swagnercarena self-assigned this Jan 25, 2024
Copy link
Owner

@swagnercarena swagnercarena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look correct, but it seems like the pip version of lenstronomy did not include this new feature when the tests were run. Let's try to get the tests to run again to make sure everything is in order now.

swagnercarena
swagnercarena previously approved these changes Jan 25, 2024
@swagnercarena
Copy link
Owner

@smericks, can you modify the lenstronomy requirements to the new pip version with this change? That should also trigger the tests to run again.

@swagnercarena swagnercarena linked an issue Jan 25, 2024 that may be closed by this pull request
Updated lenstronomy version
@smericks
Copy link
Collaborator Author

@swagnercarena @sibirrer So the switch from_import_class() to lens_class() happened Oct 27th (lenstronomy/lenstronomy@f815d06)

But the latest pip version of lenstronomy is from Sep 28th (https://github.com/lenstronomy/lenstronomy/releases/tag/v1.11.5)

So I don't think this change is compatible with a pip release of lenstronomy yet. Since I'm working with more up to date lenstronomy than the pip release, I tried to jump the gun on changing this.

@swagnercarena
Copy link
Owner

Okay, let's circle back to this pull request once the newest pip version of lenstronomy is compatible with the change. Thanks @smericks!

@sibirrer
Copy link
Collaborator

Okay, let's circle back to this pull request once the newest pip version of lenstronomy is compatible with the change. Thanks @smericks!

ah, I see. On my way for a new lenstronomy release and then ping here. Thank you!

@sibirrer
Copy link
Collaborator

@smericks @swagnercarena lenstronomy version 1.11.6 is available on pip

now requires lenstronomy >= 1.11.6
@coveralls
Copy link

Coverage Status

coverage: 94.973%. remained the same
when pulling 9956d05 on smericks:updated_lenstronomy
into 6f6e9ec on swagnercarena:main.

@swagnercarena swagnercarena merged commit 7ddce5e into swagnercarena:main Jan 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

outdated private function call in lenstronomy
4 participants