Update requirements.txt #57
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why does coverage decrease by 9% when switching the required numpy version? This seems strange @swagnercarena |
smericks
requested changes
Jun 12, 2024
paltas/MainDeflector/perturbers.py
Outdated
| - z_lens - perturber redshift | ||
| """ | ||
| # Define the parameters we expect to find for the DG_19 model | ||
| required_parameters = ('gamma','theta_E','e1','e2','center_x', |
There was a problem hiding this comment.
Need to update required parameters. You'll need to feed in new parameters for the SIS model.
paltas/MainDeflector/perturbers.py
Outdated
| lens_class(model).param_names | ||
| ) | ||
| model_kwargs = {} | ||
| for param in p_names: |
There was a problem hiding this comment.
Be careful here. Because you have both a PEMD model and an SIS model, some parameter names are shared between the two models. You might have to re-write this to account for that. (ex: both main PEMD and perturber SIS will reqiure a 'theta_E' in the lenstronomy kwargs list)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed numpy dependency from >=1.13,<=1.24 to >=1.13,<=1.23 to avoid deprecation of distutils.