Bug fix: Truncated Redshift distribution #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swagnercarena
requested changes
Jul 8, 2024
paltas/Sampling/distributions.py
Outdated
| @@ -338,7 +338,7 @@ def __init__(self, z_lens_min,z_lens_mean,z_lens_std,z_source_min, | |||
| z_source_mean,z_source_std): | |||
| # transform z_lens_min, z_source_min to be in units of std. deviations | |||
| self.z_lens_min = (z_lens_min - z_lens_mean) / z_lens_std | |||
| self.z_source_min = (z_source_min - z_source_mean) / z_source_std | |||
| self.z_source_min_default = (z_source_min - z_source_mean) / z_source_std | |||
There was a problem hiding this comment.
I would keep the original naming convention and instead change the object used in the call
paltas/Sampling/distributions.py
Outdated
| @@ -355,8 +355,9 @@ def __call__(self): | |||
| z_lens = self.z_lens_dist() | |||
| clip = (z_lens - self.z_source_mean) / self.z_source_std | |||
| # number of std. devs away to stop (negative) | |||
| if(clip > self.z_source_min): | |||
| if(clip > self.z_source_min_default): | |||
| self.z_source_min = clip | |||
There was a problem hiding this comment.
z_source_min here instead of self.z_source_min would be a cleaner fix. In the current fix a new self.property is created during the call, which doesn't seem like optimal behavior since that property is never referenced outside the call.
|
I think changing the naming as I suggested should fix the merge conflict, but we can take another look if it doesn't |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for minor bug for the RedshiftsTruncNorm class
Description of Bug:
The lower source redshift truncation value (self.z_source_min) is updated dependent on the lens redshift, but is not reset to the default/inputted value after each draw. Therefore the truncation value gradually increases as more draws are made.
Fix:
The lower truncation value is now set to the inputted value (self.z_source_min_default) in the cases that it is greater than the lens redshift.