Introduce grouped_titlebar command #8248
Conversation
kennylevinsen
force-pushed
the
grouped-titlebar
branch
from
5c53b1e
to
3e7dd34
Compare
kennylevinsen
force-pushed
the
grouped-titlebar
branch
from
3e7dd34
to
6d746a3
Compare
|
I wonder if "grouped" is the right terminology here? The i3 user guide only uses the terms "tabbed layout", "stacking layout" and "split layout". |
kennylevinsen
force-pushed
the
grouped-titlebar
branch
from
6d746a3
to
595ffce
Compare
Definitely not! I just tried to come up with a term that could cover both We could also split the setting up into stacking and tabbed versions to save us the pain of coming up with a name. |
kennylevinsen
force-pushed
the
grouped-titlebar
branch
from
595ffce
to
745c053
Compare
|
Split it into stacking/tabbed commands. |
| @@ -111,6 +111,16 @@ They are expected to be used with *bindsym* or at runtime through *swaymsg*(1). | |||
| *border* toggle | |||
| Cycles through the available border styles. | |||
|
|
|||
| *stacking_titlebar* always_visible|follows_border | |||
| Set whether the titlebar for contains with stacking layouts should always | |||
There was a problem hiding this comment.
| Set whether the titlebar for contains with stacking layouts should always | |
| Set whether the titlebar for containers with stacking layouts should always |
| other layouts. | ||
|
|
||
| *tabbed_titlebar* always_visible|follows_border | ||
| Set whether the titlebar for contains with tabbed layouts should always |
There was a problem hiding this comment.
| Set whether the titlebar for contains with tabbed layouts should always | |
| Set whether the titlebar for containers with tabbed layouts should always |
|
Seems like this is missing some files? |
Stacking and tabbed layouts effectively override the titlebar control of the border command, always showing the titlebar to allow navigation. Allow users to also hide the titlebar of stacking/tabbed layouts, through new commands that specify whether titlebars for these layouts should always be visible (the default) or if they should follow the active container's border configuration.
kennylevinsen
force-pushed
the
grouped-titlebar
branch
from
745c053
to
5b855f7
Compare
Heh, forgot to re-add after I renamed the command. |
Stacking and tabbed layouts effectively override the titlebar control of the border command, always showing the titlebar to allow navigation.
Allow users to also hide the titlebar of stacking/tabbed layouts, through a new command that specify whether grouped titlebar configurations should always be visible (the default) or if they should follow the active container's border configuration.
A take on #7409 based on one of the suggestions in #8026.
Plenty of room for bikeshedding the name and shape of the command, but the wiring should be pretty much the same regardless. It's somewhat quirky that the titlebar behavior of a tabbed/stacking container is controlled by the child, but the same goes for the border behavior right now.