Support for RGB565 render format for GUD #8320
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: wlroots!4824 is not needed to test this, as RGB565 is often supported with the DRM and wayland backends for wlroots. Setting bit depth to 6 worked fine with this PR; the only problem with the code that I noticed is that the error message in |
GUD devices uses RGB565 by default for performance reasons. Allow specifying render_bit_depth 6 to pick this format. The definition works out if you consider hte maximum number of bits per channel instead of the average.
kennylevinsen
force-pushed
the
6bitfmts
branch
from
62ebbb7
to
2e1e07f
Compare
Good point, fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GUD driver needs to use RGB565 for performance reasons, but exposes XRGB8888 with the driver doing a conversion in that case, making a fallback insufficient.
Extend the bit depth option to allow lowering to a maximum of 6 bits per channel.
Depends on https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/4824 to have any use.