This repository has been archived by the owner on Nov 1, 2021. It is now read-only.
data-device: allow multiple devices for the same seat #1384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fixes the Firefox crash when pasting the clipboard contents into the address bar. Is there anything else that should be tested? Firefox is still laggy but that's an issue with the Firefox wayland port itself. |
|
Works fine, this is the last thing needed to make firefox with wayland work here. |
|
With this fix, firefox is now perfectly usable. The lag issue has also been fixed by other commits. |
emersion
changed the title
|
This breaks copy-pasting in gnome-terminal. To reproduce: And try copy-pasting between the two terminal windows. |
emersion
force-pushed
the
data-multiple-devices
branch
from
06b5a77
to
669671f
Compare
emersion
changed the title
|
Fixed, this is ready for review. |
This commit makes it possible for a single client to have multiple data devices for the same seat. This fixes issues with Firefox. This mainly removes wlr_data_source.offer. We make sure we create one data offer per device. We now make the offer inert when the source is destroyed. Fixes the second half of swaywm#1041
The source could be used in another offer.
emersion
force-pushed
the
data-multiple-devices
branch
from
63a3e33
to
4423f88
Compare
|
Works fine now. |
ddevault
approved these changes
Nov 26, 2018
|
Thanks! |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes it possible for a single client to have multiple data devices
for the same seat. This fixes issues with Firefox.
This mainly removes wlr_data_source.offer. We make sure we create one data
offer per device. We now make the offer inert when the source is destroyed.
Fixes #1041 (the second half)