Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(visit): Add linear AST traversal #9452

Merged
merged 40 commits into from
Aug 20, 2024
Merged

perf(visit): Add linear AST traversal #9452

merged 40 commits into from
Aug 20, 2024

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Aug 19, 2024

Description:

Babel decorator pass uses fastTraverse, and I think we can have one.

Related issue:

@kdy1 kdy1 added this to the Planned milestone Aug 19, 2024
@kdy1 kdy1 self-assigned this Aug 19, 2024
Copy link

changeset-bot bot commented Aug 19, 2024

🦋 Changeset detected

Latest commit: 749e2d0

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kdy1 kdy1 changed the title perf(visit): Add linear-time visitor perf(visit): Add linear AST traversal Aug 20, 2024
@kdy1 kdy1 marked this pull request as ready for review August 20, 2024 05:00
@kdy1 kdy1 requested review from a team as code owners August 20, 2024 05:00
kodiakhq[bot]
kodiakhq bot previously approved these changes Aug 20, 2024
kodiakhq[bot]
kodiakhq bot previously approved these changes Aug 20, 2024
kodiakhq[bot]
kodiakhq bot previously approved these changes Aug 20, 2024
Copy link

codspeed-hq bot commented Aug 20, 2024

CodSpeed Performance Report

Merging #9452 will degrade performances by 4.11%

Comparing kdy1:fast-visit (749e2d0) with main (a5d3073)

Summary

❌ 1 regressions
✅ 177 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main kdy1:fast-visit Change
es/full/bugs-1 540.7 µs 563.9 µs -4.11%

@kdy1 kdy1 merged commit 911d4ea into swc-project:main Aug 20, 2024
154 checks passed
@kdy1 kdy1 deleted the fast-visit branch August 20, 2024 06:50
@kdy1 kdy1 modified the milestones: Planned, v1.7.15, v1.7.17 Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Fast iteration of AST nodes
1 participant