Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux: Download required dependencies #32

Closed
adam-fowler opened this issue Mar 20, 2023 · 3 comments · Fixed by #54
Closed

Linux: Download required dependencies #32

adam-fowler opened this issue Mar 20, 2023 · 3 comments · Fixed by #54
Assignees
Labels
linux Issues related to implementing the Linux swiftly executable
Milestone

Comments

@adam-fowler
Copy link
Contributor

See https://www.swift.org/download/#linux

@patrickfreed patrickfreed added the linux Issues related to implementing the Linux swiftly executable label Mar 26, 2023
@MahdiBM
Copy link
Contributor

MahdiBM commented Apr 6, 2023

Just want to mention that I think this is an important feature to have so I personally can start advising users to use Swiftly over https://swiftlang.xyz.

If I were to mention a second-important feature to make sure there is no longer a reason to advise https://swiftlang.xyz, it would be #42 (making sure users don't have to manually deal with PATH).

Just throwing my thoughts out here for what they're worth since I see Swiftly is approaching a release and @0xTim is hopeful we can start using Swiftly in the Vapor Discord server.

@patrickfreed patrickfreed added this to the 0.1.0 release milestone Apr 7, 2023
@patrickfreed
Copy link
Contributor

Your feedback is much appreciated, thanks for providing it! And yeah I agree, I think this and #42 are probably worth having for the initial release to help ensure good first experiences with swiftly. Regarding the dependencies, the design for swiftly has a plan for a more complicated approach to system dependencies that involves trying to detect them in case a user installed them manually, but I think for an initial release at least (if not indefinitely), just handing it in the install script is probably fine.

Regarding the PATH, ~/.local/bin is already on the PATH for most distributions, so users shouldn't have to mess with it unless they configure it otherwise. That said, sometimes it doesn't exist on the path (e.g. for the root user), and sometimes users will want to configure other directories, and in either case #42 is very useful.

@adam-fowler
Copy link
Contributor Author

Can't remember what that more complex plan was for installing dependencies. Shouldn't we leave that to apt-get or yum. We can easily add to the install script the dependency installation. We can scrap the dependencies from the docker image scripts in swift-docker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linux Issues related to implementing the Linux swiftly executable
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants