Skip to content
This repository has been archived by the owner on Sep 16, 2021. It is now read-only.

[WIP] An autocompletion plugin #101

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[WIP] An autocompletion plugin #101

wants to merge 4 commits into from

Conversation

wouterj
Copy link
Member

@wouterj wouterj commented May 10, 2015

See sonata-project/SonataDoctrinePhpcrAdminBundle#340 for the story behind this PR.

Fixes #76

@wouterj wouterj modified the milestone: 2.0 FancyTree & Resource May 10, 2015
@dbu
Copy link
Member

dbu commented May 11, 2015

cool! what is missing here?

could we support autocomplete on document titles in the same plugin? and is there a way we could limit the editable area to a sub path? although, for the scenario of having 10-100 documents to pick from, one can also use the EntityChoice dropdown, maybe with something like the chosen plugin.

@wouterj
Copy link
Member Author

wouterj commented May 11, 2015

what is missing here?

Some tests and some local testing.

@wouterj wouterj closed this May 11, 2015
@wouterj wouterj removed the wip/poc label May 11, 2015
@wouterj wouterj deleted the autocomplete branch May 11, 2015 08:01
@wouterj wouterj restored the autocomplete branch May 11, 2015 08:01
@wouterj wouterj reopened this May 11, 2015
@wouterj
Copy link
Member Author

wouterj commented May 11, 2015

Hmmm, lots of things went wrong there...

@dbu
Copy link
Member

dbu commented May 11, 2015

the good thing with git is that a branch can be restored ;-)

did you want to trigger a travis restart? for that i could also try to give you permissions to do so on travis, if you not already have them. (its the circle icon on the top right of the travis pages. there is a global one for the whole build, and one on each detail page of a matrix entry)

@wouterj
Copy link
Member Author

wouterj commented May 11, 2015

did you want to trigger a travis restart? for that i could also try to give you permissions to do so on travis, if you not already have them. (its the circle icon on the top right of the travis pages. there is a global one for the whole build, and one on each detail page of a matrix entry)

I already can restart builds. I don't know what happend exactly...

@wouterj
Copy link
Member Author

wouterj commented May 11, 2015

could we support autocomplete on document titles in the same plugin?

This plugin is using the HTML 5 datalist element. Browser inconsistently support it (Chrome matches both label and value, FireFox matches only label, etc). However, I just discovered datalist is not supported by IE 9 and Safari, so I have to rewrite it (and may use a jQuery autocomplete plugin for that part).

@dbu
Copy link
Member

dbu commented May 15, 2015

even the latest safari? i would have no problem saying that this only works with IE10+ for windows users. is safari even still relevant? or is everybody on mac using chrome anyways?

@ElectricMaxxx
Copy link
Member

can you rebase please?

@wouterj wouterj modified the milestones: 2.1, 2.0 Jan 29, 2017
@wouterj
Copy link
Member Author

wouterj commented Jan 29, 2017

Skipped this PR for 2.0. It's not required and needs lots of love.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pimp the tree selector user experience in edit forms
4 participants