Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed fix to segmentation fault #425

Closed
wants to merge 4 commits into from
Closed

Conversation

kirichoi
Copy link

This is proposed fix to segmentation fault caused by fix to issue #411.
Added extra step that checks 'time' is part of the selection.

@0u812
Copy link
Member

0u812 commented Oct 11, 2017

This fixes the segfault, but I don't think the behavior is correct for models with events. I don't think time-shifting the output row will work in general.

Antimony:

model mymodel()
  var species X = 10
  at time>=5: X = 5
end

Python:

mymodel.reset()
mymodel.simulate(-5,5,100)
mymodel.plot()

screen shot 2017-10-11 at 1 48 08 pm

@kirichoi
Copy link
Author

I see. This requires a bit more complex solution.

@kirichoi kirichoi closed this Oct 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants