Enable negative start times. #854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I thought this would be much more difficult than it turned out to be, because our current 'start' time is not 'time to start collecting data' but 'the time that the model is currently in', which is quite different! The trickiest part of this turns out to be events, which had t0=0.0 hard-coded in quite a number of places. Still need to test more, but many things now work with negative start times--events can fire pre-0.0, even. So hey!
Also, put its initialization in a new base class constructor, and call that constructor from the subclass constructors, instead of individually setting the value. Also also, adjust time vector setting to allow negative time outputs. Start to test Gillespie; not done yet.
Also, add a bunch of tests. Also also, it turns out that events that fire at t0 with delay don't interact well with non-zero start times (nor do events that fire at t0 with 'time' in the trigger). But that's a separate issue and doesn't involve only negative start times; I'll deal with that separately.
Now that it has a memeber variable, it needs to initialize it. The default constructor was indeed being used elsewhere; I couldn't make the constructor private.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought this would be much more difficult than it turned out to be, because our current 'start' time is not 'time to start collecting data' but 'the time that the model is currently in', which is quite different!
The trickiest part of this turns out to be events, which had t0=0.0 hard-coded in quite a number of places. Still need to test more, but many things now work with negative start times--events can fire pre-0.0, even. So hey!