Skip to content

Commit

Permalink
Add newline to last pr_info to force dmesg to flush
Browse files Browse the repository at this point in the history
dmesg only flushes when it encounter a newline. Without a newline, the line
is held in memory pending another printk. In this particular example
(example_atomic.c), the last pr_info in atomic_bitwise() prints when
another printk happens (either by another module, or __exit for this
module.

This can be confusing to new learner. This patch adds a newline to the last
pr_info forcing dmesg to print to the screen when the module is loaded.
  • Loading branch information
mechanicalamit committed Sep 28, 2023
1 parent 7f88a37 commit e56fc58
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion examples/example_atomic.c
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ static void atomic_bitwise(void)
pr_info("Bits 4: " BYTE_TO_BINARY_PATTERN, BYTE_TO_BINARY(word));

word = 255;
pr_info("Bits 5: " BYTE_TO_BINARY_PATTERN, BYTE_TO_BINARY(word));
pr_info("Bits 5: " BYTE_TO_BINARY_PATTERN "\n", BYTE_TO_BINARY(word));
}

static int __init example_atomic_init(void)
Expand Down

0 comments on commit e56fc58

Please sign in to comment.