Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The process of "seq_file" lacks some descriptions #261

Closed
jouae opened this issue Jul 2, 2024 · 1 comment
Closed

The process of "seq_file" lacks some descriptions #261

jouae opened this issue Jul 2, 2024 · 1 comment

Comments

@jouae
Copy link
Contributor

jouae commented Jul 2, 2024

7.4 The seq_file is missing the behavior that occurs when it directly returns NULL after the start step. Also, in the flowchart, the first decision where return is NULL is yes points to nothing, which is not defined in ISO 5807.

ISO 5807 section 10.3.1.2 states decision, "Each exit from a symbol be accompanied by the appropriate condition values to show the logic path which it represents, so that the conditions and the associated references are identified."

The behavior of pointing to nothing does not have associated references and does not indicate the relation of this logic path.

My suggestions are:
1. Add a description of this behavior: "If the return is a non-NULL value, the function next() is called; otherwise, the stop() function is called directly."
2. Additionally, in the flowchart, the yes logic path of the first decision should point to the stop() treatment.

Refs:
7.4 Manage /proc file with seq_file
ISO-5807-1985

@jouae jouae closed this as completed Jul 2, 2024
@jouae
Copy link
Contributor Author

jouae commented Jul 2, 2024

Closed see commit #262

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant