Modify the descritions of seq_file and flowchart #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7.4 The seq_file is missing the behavior that occurs when it directly returns NULL after the start step. Also, in the flowchart, the first decision where `return is NULL` is `Yes` points to nothing, which is not defined in ISO 5807. ISO 5807 section 10.3.1.2 states logic path of a decision, "Each exit from a symbol be accompanied by the appropriate condition values to show the logic path which it represents, so that the conditions and the associated references are identified." The behavior of pointing to nothing does not have associated references and does not indicate the relation of this logic path. Refs: 1. The Liunx Kernel Module Programming Guide 7.4 Manage /proc file with seq_file 2. ISO-5807-1985
|
Thank @jouae for contributing! |
|
I find a typo duplicated word "otherwise", let me fix it when I get off work today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
7.4 The seq_file is missing the behavior that occurs when it directly returns NULL after the start step.
Also, in the flowchart, the first decision where
return is NULLisYespoints to nothing, which is not defined in ISO 5807.ISO 5807 section 10.3.1.2 states logic path of a decision, "Each exit from a symbol be accompanied by the appropriate condition values to show the logic path which it represents, so that the conditions and the associated references are identified."
The behavior of pointing to nothing does not have associated references and does not indicate the relation of this logic path.
Refs:
1. The Liunx Kernel Module Programming Guide 7.4 Manage /proc file with seq_file
2. ISO-5807-1985