Remove module * parameter from class_create() #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- From v6.4, class_create() does not have module * (See commit 11ba11 below) - Added #ifdev for KERNEL_VERSION >= 6.4 From linux commit aaba11da9aa7d7d6b52a74d45b31cac118295a1 --------------------------------------------- driver core: class: remove module * from class_create() The module pointer in class_create() never actually did anything, and it shouldn't have been requred to be set as a parameter even if it did something. So just remove it and fix up all callers of the function in the kernel tree at the same time.
mechanicalamit
force-pushed
the
chardev.c-v6.4
branch
from
2bdc30c
to
82cb3b7
Compare
linD026
requested changes
Sep 2, 2023
linD026
approved these changes
Sep 2, 2023
jserv
requested changes
Sep 2, 2023
jserv
changed the title
|
Thank @mechanicalamit for contributing! |
Thank you @jserv, for guiding me through. |
mechanicalamit
added a commit
to mechanicalamit/lkmpg
that referenced
this pull request
Sep 17, 2023
From v6.4, class_create() does not have module * Same fix as (sysprog21#222), commit 0addb86 to chardev.c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(See commit 11ba11 below)
From linux commit aaba11da9aa7d7d6b52a74d45b31cac118295a1
driver core: class: remove module * from class_create()
The module pointer in class_create() never actually did anything,
and it shouldn't have been requred to be set as a parameter even
if it did something. So just remove it and fix up all callers of the
function in the kernel tree at the same time.