This repository has been archived by the owner on Oct 9, 2020. It is now read-only.
Output to memory #63
Merged
Output to memory #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisptrutski
force-pushed
the
memory-output
branch
from
9558483
to
c85421d
Compare
crisptrutski
force-pushed
the
memory-output
branch
3 times, most recently
from
0c13068
to
ed5b349
Compare
| content += '\n//# sourceMappingURL=data:application/json;base64,' + | ||
| new Buffer(output.sourceMap.toString()).toString('base64'); | ||
| } | ||
| return wrapPromise(content); |
There was a problem hiding this comment.
You can just do Promise.resolve(content) here.
|
👍 perhaps just |
|
Yeah, makes the tests for #58 easier too.. Was originally intending to send to standard output for CLI usage, hence the inline-ing, but would need to disable all the other logging though, so perhaps reserve a flag for that. Not sure if people would actually want to use it this way though. |
|
Ok great. Yeah CLI streaming can be implemented if and when there is demand, happy to leave it out for now. |
|
Points addressed, let me know if I should squash |
|
Awesome, thanks. Are the source maps looking like they're working? |
|
Looking good for non-chained. Will squash get this merged, look at the chaining in #64 |
crisptrutski
force-pushed
the
memory-output
branch
from
9d67e15
to
386226a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@guybedford let me know if you're happy with this approach, most notably the API (return file-contents string within promise).
Perhaps a stream is more suitable, and I'm not sure what was meant by "memory FS". Looked at things like https://github.com/tschaub/mock-fs, but that sort of evil seems doesn't seem to belong outside of testing, and not sure the value it would add in the scenario vs return an inlined-file or a dictionary of the separate files.
Need to hook up Uglify for in-memory usage, and refactor my goop (been a while, JavaScript)
Closes #54